This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Ensure the shape of input patches is compatible with model constraints#682
Merged
Conversation
Update CHANGELOG Fix transform being passed to itself Add correct changes to inference file
85bcecd to
fade6c3
Compare
Shruthi42
previously approved these changes
Mar 8, 2022
|
|
||
|
|
||
| def test_inference_on_too_small_image() -> None: | ||
| """ |
Contributor
Author
There was a problem hiding this comment.
Because images will never be too small after merging
Contributor
There was a problem hiding this comment.
The other PR does not have tests. Is it not possible to have a test to demonstrate that this is correct?
Contributor
Author
There was a problem hiding this comment.
I believe all this is covered by the tests in https://github.com/microsoft/InnerEye-DeepLearning/blob/main/Tests/ML/models/architectures/test_crop_size_multiple.py
javier-alvarez
approved these changes
Mar 10, 2022
ant0nsc
approved these changes
Mar 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change uses TorchIO's
EnsureShapeMultipleto ensure that the inputs are a multiple of certain number which is specified in the model size constraints.